Skip to content

reduce dependencies in measurable_structure.v#1979

Merged
affeldt-aist merged 7 commits into
math-comp:masterfrom
affeldt-aist:measurable_structure_20260527
Jun 29, 2026
Merged

reduce dependencies in measurable_structure.v#1979
affeldt-aist merged 7 commits into
math-comp:masterfrom
affeldt-aist:measurable_structure_20260527

Conversation

@affeldt-aist

@affeldt-aist affeldt-aist commented May 27, 2026

Copy link
Copy Markdown
Member
Motivation for this change

fyi @hoheinzollern

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist force-pushed the measurable_structure_20260527 branch from 8495d56 to 6fbaccd Compare June 16, 2026 10:43
@affeldt-aist affeldt-aist marked this pull request as ready for review June 16, 2026 12:13
@affeldt-aist

Copy link
Copy Markdown
Member Author

This is really just reducing dependencies in measurable_structure.v, so a clear improvement.

@t6s t6s left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Qed.

Lemma bigcup_bigsetU_bigcup F :
\bigcup_k \big[setU/set0]_(i < k.+1) F i = \bigcup_k F k.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not about this PR itself, but why do lemmas around here have .+1 in the indexing for finite parts?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bigcup_bigsetU_bigcup can indeed be changed but of course it like adding an empty set to the big union
so I am not sure it is interesting, what do you think at the look of the last commit?

If by "around" you mean the next lemma bigcup_mkord_ord, this is inherent to the use of inord.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I would like to revert the last commit (eba1042) that experiments with changing the statement of bigcup_bigsetU_bigcup, not really convincing to me.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it then.

@t6s

t6s commented Jun 22, 2026

Copy link
Copy Markdown
Member

One action in the CI is failing, complaining xfinmap is not found. What is xfinmap?

@hoheinzollern hoheinzollern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment about notation, looks good.

Definition bigcup2 T (A B : set T) : nat -> set T :=
Definition sequence R := nat -> R.

Notation "R ^nat" := (sequence R) : type_scope.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this notation introduced here? isn't it part of mathcomp already?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not part of mathcomp.
I am not sure it is going to make it to mathcomp soon because it is about sequences and their theory is really developed in MathComp-Analysis.
This is the reason why I haven't even thought of moving it to unstable.v (the staging area).

Comment thread theories/sequences.v Outdated
@affeldt-aist affeldt-aist force-pushed the measurable_structure_20260527 branch from cf0a729 to 9d49866 Compare June 27, 2026 17:07
@affeldt-aist affeldt-aist force-pushed the measurable_structure_20260527 branch 2 times, most recently from 0c132da to ee251df Compare June 28, 2026 18:21
@affeldt-aist

Copy link
Copy Markdown
Member Author

Thanks for the reviews @t6s @hoheinzollern . I'll merge when the CI is green.

@affeldt-aist affeldt-aist merged commit c3642aa into math-comp:master Jun 29, 2026
45 checks passed
@affeldt-aist affeldt-aist deleted the measurable_structure_20260527 branch June 29, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants